Skip to content
Snippets Groups Projects
  1. Jul 29, 2016
  2. Jul 20, 2016
  3. Jul 11, 2016
  4. May 20, 2016
    • Joas Schilling's avatar
      Move tests/ to PSR-4 (#24731) · 94ad54ec
      Joas Schilling authored
      * Move a-b to PSR-4
      
      * Move c-d to PSR-4
      
      * Move e+g to PSR-4
      
      * Move h-l to PSR-4
      
      * Move m-r to PSR-4
      
      * Move s-u to PSR-4
      
      * Move files/ to PSR-4
      
      * Move remaining tests to PSR-4
      
      * Remove Test\ from old autoloader
      94ad54ec
  5. May 18, 2016
  6. Apr 22, 2016
  7. Apr 15, 2016
  8. Jan 28, 2016
    • Lukas Reschke's avatar
      Add public API to give developers the possibility to adjust the global CSP defaults · 809ff5ac
      Lukas Reschke authored
      Allows to inject something into the default content policy. This is for
      example useful when you're injecting Javascript code into a view belonging
      to another controller and cannot modify its Content-Security-Policy itself.
      Note that the adjustment is only applied to applications that use AppFramework
      controllers.
      
      To use this from your `app.php` use `\OC::$server->getContentSecurityPolicyManager()->addDefaultPolicy($policy)`,
      $policy has to be of type `\OCP\AppFramework\Http\ContentSecurityPolicy`.
      
      To test this add something like the following into an `app.php` of any enabled app:
      ```
      $manager = \OC::$server->getContentSecurityPolicyManager();
      $policy = new \OCP\AppFramework\Http\ContentSecurityPolicy(false);
      $policy->addAllowedFrameDomain('asdf');
      $policy->addAllowedScriptDomain('yolo.com');
      
      $policy->allowInlineScript(false);
      $manager->addDefaultPolicy($policy);
      $policy = new \OCP\AppFramework\Http\ContentSecurityPolicy(false);
      $policy->addAllowedFontDomain('yolo.com');
      $manager->addDefaultPolicy($policy);
      
      $policy = new \OCP\AppFramework\Http\ContentSecurityPolicy(false);
      $policy->addAllowedFrameDomain('banana.com');
      $manager->addDefaultPolicy($policy);
      ```
      
      If you now open the files app the policy should be:
      
      ```
      Content-Security-Policy:default-src 'none';script-src yolo.com 'self' 'unsafe-eval';style-src 'self' 'unsafe-inline';img-src 'self' data: blob:;font-src yolo.com 'self';connect-src 'self';media-src 'self';frame-src asdf banana.com 'self'
      ```
      809ff5ac
  9. Nov 30, 2015
    • Lukas Reschke's avatar
      Show error template · f4eb15d3
      Lukas Reschke authored
      Otherwise this leads to an endless redirection in case of a CSRF exception. Also sets user expectation right.
      f4eb15d3
  10. Oct 21, 2015
  11. Aug 13, 2015
    • Lukas Reschke's avatar
      Add mitigation against BREACH · 8313a3fc
      Lukas Reschke authored
      While BREACH requires the following three factors to be effectively exploitable we should add another mitigation:
      
      1. Application must support HTTP compression
      2. Response most reflect user-controlled input
      3. Response should contain sensitive data
      
      Especially part 2 is with ownCloud not really given since user-input is usually only echoed if a CSRF token has been passed.
      
      To reduce the risk even further it is however sensible to encrypt the CSRF token with a shared secret. Since this will change on every request an attack such as BREACH is not feasible anymore against the CSRF token at least.
      8313a3fc
  12. Feb 16, 2015
  13. Feb 09, 2015
    • Lukas Reschke's avatar
      Respect `mod_unique_id` and refactor `OC_Request::getRequestId` · 770fa761
      Lukas Reschke authored
      When `mod_unique_id` is enabled the ID generated by it will be used for logging. This allows for correlation of the Apache logs and the ownCloud logs.
      
      Testplan:
      
      - [ ] When `mod_unique_id` is enabled the request ID equals the one generated by `mod_unique_id`.
      - [ ] When `mod_unique_id` is not available the request ID is a 20 character long random string
      - [ ] The generated Id is stable over the lifespan of one request
      
      Changeset looks a little bit larger since I had to adjust every unit test using the HTTP\Request class for proper DI.
      
      Fixes https://github.com/owncloud/core/issues/13366
      770fa761
  14. Nov 19, 2014
  15. Nov 15, 2014
  16. Jul 01, 2014
  17. May 28, 2014
  18. May 11, 2014
  19. Apr 20, 2014
  20. Feb 19, 2014
  21. Oct 23, 2013
  22. Oct 16, 2013
  23. Oct 11, 2013
  24. Oct 07, 2013
  25. Oct 01, 2013
  26. Aug 20, 2013
  27. Aug 17, 2013
Loading